Fix callout spacing for new callouts (sans icons) #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks @wustep 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See issue #565
Notion recently introduced two changes to callouts:
<h1>at the top of a callout.This led to some minor visual issues with react-notion-x.
In this PR, we:
Notion Test Page ID
1425cb08cf2c80efb771e6010d8dac21
Notion
Main [before change]
https://react-notion-x-demo.transitivebullsh.it/1425cb08cf2c80efb771e6010d8dac21
After change
Old callouts are fine too
(Note: there seems to be a funny bug with adjacent headings being rendered on the same line 😛. This is not addressed in this PR.)